✨ Add ability to log runtime floating-point values #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - The binary logging does not support floating-point values (`float` and `double`). Solution: - Separate argument encoding/packing into a type so that it can be customized, and passed through builders. - Allow `float` and `double` to encoded/packed. - Support `%f` specifiers in JSON collateral. Note: - The MIPI-SysT spec v1.1 (section 9.2 table 16) specifies that a `float` is packed into 64 bits even when using 32-bit packing. This implementation packs a `float` into 32 bits by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
floatanddouble).Solution:
floatanddoubleto encoded/packed.%fspecifiers in XML collateral.Note:
floatis packed into 64 bits even when using 32-bit packing. This implementation packs afloatinto 32 bits by default.